Update mime type for DCM format #287
Conversation
There was a problem hiding this comment.
Hello, and thank you for your contribution! You cannot modify the db.json file directly, as it is a generated file and changes you make will be overwritten. Please see contribution instructions at https://github.com/jshttp/mime-db#contributing . When you update the custom file, please include the source of your information, which should clearly state the extension is for this mime type and not be a prohibited site. Thank you!
|
Thanks for the reply, update the |
| @@ -501,6 +501,12 @@ | |||
| "application/zip": { | |||
| "compressible": false | |||
| }, | |||
| "application/dicom": { | |||
| "source": [ | |||
| "https://en.wikipedia.org/wiki/DICOM" | |||
There was a problem hiding this comment.
This needs to be a link to a primary source; Wikipedia is even specifically called out as not acceptable in the README: https://github.com/jshttp/mime-db#direct-inclusion
There was a problem hiding this comment.
See instead:
- DICOM Key Concepts
DICOM files typically have a .dcm file extension if they are not part of a DICOM media (which requires them to be without extension).
- DICOM PS3.10 2023c - Media Storage and File Format for Media Interchange
DICOM files stored on interchange media may have an alternate file name or link that uses less restricted file names, such as a filename extension (e.g., ".dcm" in accordance with [RFC3240]).
- DICOM PS3.12 2023c - Media Formats and Physical Media for Media Interchange
- "name" is constructed from the last DICOM File ID component (that means the "file name" without "path" information) and the extension ".dcm" (except for the DICOMDIR).
For example: "I00023.dcm"
- RFC 3240
- File extension(s): ".dcm" is recommended for files saved to disk (other than DICOMDIR)
There was a problem hiding this comment.
Additionally, "application/dicom" is already present in src/iana-types.json:
Lines 607 to 612 in a76e5a8
You should probably add "extensions": ["dcm"] at the above location, like #295.
Kindly update this block